john/svsmspcalc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

css: tokenize admin fee margins + remove redundant inline style — spacing audit pass 3

Browse Source 
Replaced 2 hardcoded 6px margin-bottom values with var(--space-xs) in admin-fee-header
and admin-waive-savings. Removed redundant inline style="margin-bottom:16px" from sec-01
subtitle (handled by section-content * + * rule). Full visual audit across Dark/Light/Glass
at 1920px, print media, and mobile (375px/600px/780px landscape) — no regressions found.
Updated SESSION-HANDOFF, CLAUDE.md, DECISION-LOG, KNOWN-ISSUES, and MASTER-SESSION-PROMPT.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
John OReilly
2026-03-16 15:28:49 -04:00
parent e6c0baef3b
commit e462953a2a
7 changed files with 359 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
docs/KNOWN-ISSUES.md Normal file
View File

@@ -0,0 +1,24 @@
# Known Issues & Deferred Work — SVS MSP Calculator
Items tracked here are intentional deferrals, not bugs. Check this list before starting new work.
---
## Deferred Work
| # | Item | Severity | Source | Notes |
|---|------|----------|--------|-------|
| D1 | Spacing token consolidation | Low | Stage 8 audit | 150+ magic-number px values across components.css. Needs dedicated stage. |
| D2 | `fmt()` duplicated in quote-render.js and quote-export.js | Low | Stage 3 audit | Both inside IIFEs — intentional isolation. One-liner formatter. |
| D3 | Retro theme full design pass | Low | Stage 5 | Warm paper/neon palette functional but not polished. CSS file retained. |
| D4 | Retro theme QA at all viewports | Low | Stage 5 | Only mobile verified during overhaul. Desktop/wide not fully tested. |
| D5 | Sections IV–VI content activation | Medium | Master prompt | Server, ZT Networking, VoIP — structurally complete, content gated. Engine calculates when inputs present. |
## Known Quirks (Intentional)
| # | Quirk | Why It's OK |
|---|-------|-------------|
| Q1 | Glass theme uses 97 `!important` declarations | Standard glassmorphism override pattern — theme must beat compound parent selectors |
| Q2 | `console.warn()` in pricing/persistence/import | Intentional error reporting for debugging — not dead code |
| Q3 | 70retro.css still in repo but not in theme cycle | Retained for potential future revival per decision log |
| Q4 | Sidebar focus toggle uses white rgba on colored header | Correct in all themes — verified during Phase 2 audit |